Conversation
Rotti2
left a comment
Rotti2
left a comment
There was a problem hiding this comment.
Hi, thank you very much for your contribution!
I have added some comments to your pull request that we need to resolve before merging it. Especially the duplicated logic for the txt file parsing is not ideal.
Tell me if you need any help resolving the issues. I am happy to help :)
Regarding your issues on running Singularity locally, i have added a Getting Started with local development section to the readme.md. I am also happy to help (or to adjust the readme) if you have any issues there. I hope it helps!
| <button suiButton | ||
| [disabled]="isIndexing" | ||
| (click)="startIndexing()"> | ||
| <sui-loader *ngIf="isIndexing" class="sui-space-right"></sui-loader> |
There was a problem hiding this comment.
You do not need to use the sui-loader here. The Button component has the attribute [loading], which you can set to true or false. See for example: https://github.com/Singularity-Game/Singularity/blob/main/apps/singularity-client/src/app/management/songs/create-song/create-song.component.html#L52
| padding: 1rem; | ||
| border: 1px solid var(--sui-border-color, #ddd); | ||
| border-radius: 8px; | ||
| background: var(--sui-background-color-light, #f9f9f9); |
There was a problem hiding this comment.
The background makes the text unreadable:
Removing the background should fix the issue.
|
Thanks for the feedback! The last point is a bit embarassing, I should've caught that when trying things out 😅 I unfortunately haven't had much time the last few days, but look forward to addressing those issues in the coming few, just wanted to give you a heads-up. Thanks! |
|
Finally got around to incorporating your feedback, sorry for taking so long 😅 What do you think about the new UltrastarParser, does that work? Oh and thanks for the added guidelines in getting started with local development! That really helped! :) |
|
Thanks for your contribution :) |
|
Woohoo, thanks for merging! |
2 participants
This adds a feature (optional via
ENABLE_AUTO_INDEXING) to automatically index the song directory.Full transparency: I'm unfamiliar with Angular and NestJS and had Claude Code help me out with this.
Whilst this feature alone appears to work great on my machine, I can't get the rest of Singularity to work, either on this branch or on
main. I hope that's not just an issue on my end, but maybe a currently broken state?I also had to bump the version of the builder image in the dockerfile to get the build to work.
This closes #22.